fix: the ASCII whitespaces are preserved so can not be escaped #1632
Conversation
JounQin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1632 +/- ##
==========================================
+ Coverage 96.15% 96.50% +0.34%
==========================================
Files 10 10
Lines 1196 1201 +5
Branches 461 460 -1
==========================================
+ Hits 1150 1159 +9
Misses 37 37
+ Partials 9 5 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| color: red; | ||
| } | ||
|
|
||
| .\\ > .\\ > .\\ { | ||
| .- > .- > .- { | ||
| color: red; | ||
| } | ||
| ", |
There was a problem hiding this comment.
Let's add a test case
a-b { }
a\C20b { } /* i.e. with spaces */The main problem we need to generate different CSS selectors for such case.
Even more - I think we should replace each control character on own unique symbol, we can generate it from code the character, so even special characters will always generate and unique selector. What do you think?
There was a problem hiding this comment.
Let's add a test case
OK, I'll add such case soon.
The main problem we need to generate different CSS selectors for such case.
Even more - I think we should replace each control character on own unique symbol, we can generate it from code the character, so even special characters will always generate and unique selector. What do you think?
That could work as expected, but is that common to have different white spaces in a single project? Is that a bit over engineering? But I'm also fine if you have strong opinion on this. What the symbol map would you prefer?
There was a problem hiding this comment.
That could work as expected, but is that common to have different white spaces in a single project?
Usually no, but I think we can solve it more universal for any exotic cases, usually developers don't use such characters in path and in CSS selectors too 😄
I think we can just generate use number of a character... yeah it will create more longer CSS selectors, maybe we can use some compression algorithm here to get less length
There was a problem hiding this comment.
usually developers don't use such characters in path and in CSS selectors too
I got this issue because we installed a common package in global mode. What means whenever css-loader is installed as global, it will be an issue for macOS at least with Application Support dir.
There was a problem hiding this comment.
@JounQin got it, let's fix it
This PR contains a:
Motivation / Use-Case
close #1626
Breaking Changes
N/A
Additional Info
related https://infra.spec.whatwg.org/#ascii-whitespace
cc @alexander-akait