Pr/fix async checks when calling queries member expressions #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running Program:exit(), nodes were tested again unnecessarily for isAwaited and isPromiseResolved
|
I seem to be missing one path in the test cases. I'll take a look and update it later. |
First, abstract a isQueryUsage function to check if a node should be checked for this rule. Then, add new selector for queries being called as part of MemberExpression and check their parent against the rule. Finally, use the queryName prop to make sure the right error message is printed
First, abstract reportError function. Then, create selector for MemberExpression queries.
victorandcode
force-pushed
the
pr/fix-async-checks-when-calling-queries-member-expressions
branch
from
2759d40 to
a7fca52
Compare
Belco90
approved these changes
Apr 19, 2020
|
🎉 This PR is included in version 3.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @victorandcode for code, test and bug |
|
I've put up a pull request to add @victorandcode! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes 113. It updates 2 rules:
await-async-queryandno-await-sync-queryHow
Demo
await-async-query
Before:
After
no-await-sync-query
Before:
After:
