Skip to content

fix(es/parser): Parse await using() call #9693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2024
Merged

fix(es/parser): Parse await using() call #9693

merged 5 commits into from
Oct 31, 2024

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari requested a review from a team as a code owner October 30, 2024 11:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3aae523

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 30, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9693 will improve performances by 4.32%

Comparing magic-akari:fix/issue-9688 (3aae523) with main (6ed1715)

Summary

⚡ 3 improvements
✅ 191 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:fix/issue-9688 Change
⚡ es/visitor/base-perf/boxing_boxed 3.4 µs 3.3 µs +3.59%
⚡ es/visitor/base-perf/boxing_boxed_clone 2.4 µs 2.3 µs +3.76%
⚡ es/visitor/base-perf/boxing_unboxed 3.5 µs 3.4 µs +4.32%

@kdy1 kdy1 added this to the Planned milestone Oct 30, 2024
@kdy1 kdy1 requested a review from a team as a code owner October 31, 2024 01:32
@kdy1 kdy1 merged commit bcf05de into swc-project:main Oct 31, 2024
20 of 22 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.41 Oct 31, 2024
@magic-akari magic-akari deleted the fix/issue-9688 branch November 1, 2024 10:54
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.7.42
Development

Successfully merging this pull request may close these issues.

await keyword is dropped when calling function named using
2 participants
@magic-akari @kdy1