Skip to content

fix(es/minifier): Preserve block with block scoped declaration #10335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

fix(es/minifier): Preserve block with block scoped declaration #10335

merged 3 commits into from
Apr 10, 2025

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Apr 9, 2025

Description:

BREAKING CHANGE:

Related issue (if exists):
Closes #10328

@Austaras Austaras requested a review from a team as a code owner April 9, 2025 07:18
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c719136

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10335 will not alter performance

Comparing Austaras:block (9d4b3db) with main (3f71776)

Summary

✅ 152 untouched benchmarks

@kdy1 kdy1 added this to the Planned milestone Apr 9, 2025
@kdy1 kdy1 self-assigned this Apr 9, 2025
@kdy1 kdy1 requested a review from a team as a code owner April 9, 2025 08:16
kdy1
kdy1 approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 enabled auto-merge (squash) April 9, 2025 08:17
@kdy1 kdy1 disabled auto-merge April 10, 2025 01:57
@kdy1 kdy1 merged commit a4ac3b7 into swc-project:main Apr 10, 2025
161 of 165 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.11.19 Apr 10, 2025
@GiveMe-A-Name GiveMe-A-Name mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.11.19
Development

Successfully merging this pull request may close these issues.

Compress emits let outside of block in v1.11.12 - v1.11.13
2 participants
@Austaras @kdy1