Skip to content

perf(es/fast-lexer): Optimize lexing of keywords #10155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

perf(es/fast-lexer): Optimize lexing of keywords #10155

merged 2 commits into from
Mar 6, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 6, 2025

Description:

This PR adds a fast lookup table for keyword lexing.

@kdy1 kdy1 added this to the Planned milestone Mar 6, 2025
@kdy1 kdy1 self-assigned this Mar 6, 2025
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: ddd3128

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #10155 will improve performances by 3.04%

Comparing kdy1/fl2 (ddd3128) with main (65d23fe)

Summary

⚡ 2 improvements
✅ 150 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
es/fast-lexer/backbone 1.3 ms 1.3 ms +3.04%
es/fast-lexer/mootools 5.5 ms 5.3 ms +3.02%

@kdy1 kdy1 marked this pull request as ready for review March 6, 2025 19:14
@kdy1 kdy1 requested a review from a team as a code owner March 6, 2025 19:14
@kdy1 kdy1 merged commit fb610b0 into main Mar 6, 2025
169 checks passed
@kdy1 kdy1 deleted the kdy1/fl2 branch March 6, 2025 19:15
@kdy1 kdy1 modified the milestones: Planned, v1.11.8 Mar 7, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant