Skip to content

fix(es/lints): Capture errors and emit from the original thread #10119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 27, 2025

Description:

This is to avoid potential regressions due to implementation details of swc_common::errors::Emitter.

@kdy1 kdy1 added this to the Planned milestone Feb 27, 2025
@kdy1 kdy1 self-assigned this Feb 27, 2025
@kdy1 kdy1 requested review from a team as code owners February 27, 2025 11:02
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 27, 2025
Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 0843092

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 27, 2025
@kdy1 kdy1 merged commit 2304cd8 into main Feb 27, 2025
4 checks passed
@kdy1 kdy1 deleted the kdy1/linter-capture branch February 27, 2025 11:02
Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #10119 will degrade performances by 5.14%

Comparing kdy1/linter-capture (61d7b7f) with main (207a13f)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 189 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/jquery 134.3 ms 128.5 ms +4.51%
es/minifier/libs/moment 82.1 ms 86.5 ms -5.14%

@kdy1 kdy1 modified the milestones: Planned, v1.11.5 Feb 28, 2025
kdy1 added a commit to vercel/next.js that referenced this pull request Mar 6, 2025
### What?

ChangeLog:
swc-project/swc@swc_core@v16.0.0...swc_core@v16.4.0

### Why?

To apply swc-project/swc#10119 and fix random panics.

---------

Co-authored-by: CPunisher <1343316114@qq.com>
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant