Skip to content

chore(es/minifier): Make minify-all example ignore parsing errors #10045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 18, 2025

Description:

We don't care

@kdy1 kdy1 requested a review from a team as a code owner February 18, 2025 04:34
@kdy1 kdy1 added this to the Planned milestone Feb 18, 2025
Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 2d87b85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 merged commit 6c7ec46 into swc-project:main Feb 18, 2025
18 checks passed
@kdy1 kdy1 deleted the min-bug branch February 18, 2025 04:34
@kdy1 kdy1 modified the milestones: Planned, v1.10.18 Feb 19, 2025
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #10045 will degrade performances by 4.87%

Comparing kdy1:min-bug (2d87b85) with main (6c7ec46)

Summary

❌ 3 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 162.6 ms 170.2 ms -4.51%
es/full/minify/libraries/moment 102.3 ms 105.7 ms -3.26%
es/minifier/libs/jquery 128.1 ms 134.7 ms -4.87%

@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant