Skip to content

Commit eee73ce

Browse files
kdy1magic-akari
andauthored
test(es): Unignore tests and update node to 20 in exec tests (#10348)
Co-authored-by: magic-akari <akari.ccino@gmail.com>
1 parent 1a28baa commit eee73ce

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

.github/workflows/CI.yml

+3-5
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ jobs:
108108

109109
- uses: actions/setup-node@v4
110110
with:
111-
node-version: "18"
111+
node-version: "20"
112112
cache: "yarn"
113113

114114
- name: Install node dependencies
@@ -156,7 +156,7 @@ jobs:
156156

157157
- uses: actions/setup-node@v4
158158
with:
159-
node-version: "18"
159+
node-version: "20"
160160
cache: "yarn"
161161

162162
- name: Install node dependencies
@@ -211,7 +211,7 @@ jobs:
211211
# Source map format
212212
- uses: actions/setup-node@v4
213213
with:
214-
node-version: "18"
214+
node-version: "20"
215215
cache: "yarn"
216216

217217
# We explicitly do this to cache properly.
@@ -268,8 +268,6 @@ jobs:
268268
path: |
269269
.swc-exec-cache
270270
key: swc-exec-cache-${{ matrix.settings.crate }}-${{ hashFiles('**/Cargo.lock') }}
271-
restore-keys: |
272-
swc-exec-cache-${{ matrix.settings.crate }}
273271

274272
- name: Run cargo test
275273
if: matrix.settings.crate != 'swc_plugin_runner' && matrix.settings.crate != 'swc_ecma_parser' && matrix.settings.crate != 'swc_ecma_minifier' && matrix.settings.crate != 'swc_core' && matrix.settings.crate != 'swc_ecma_quote' && matrix.settings.crate != 'swc_cli' && matrix.settings.crate != 'binding_core_wasm'

crates/swc/tests/stacktrace/issue-9742/output/stacks.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ $DIR/tests/stacktrace/issue-9742/input/index.js:3
44

55

66
Error: foo
7-
at constructor ($DIR/tests/stacktrace/issue-9742/input/index.js:3:15)
8-
at Parent ($DIR/tests/stacktrace/issue-9742/input/index.js:7:1)
7+
at new constructor ($DIR/tests/stacktrace/issue-9742/input/index.js:3:15)
8+
at new Parent ($DIR/tests/stacktrace/issue-9742/input/index.js:7:1)
99
at Object.<anonymous> ($DIR/tests/stacktrace/issue-9742/input/index.js:11:1)

tests.yml

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ os:
1919
- swc_plugin_runner
2020
- swc_plugin_testing
2121
macos:
22+
- swc
2223
- swc_allocator
2324
- swc_plugin_runner
2425

0 commit comments

Comments
 (0)