fix(es/proposal): Fix scope of declarations for explicit-resource-management (#10362)

**Related issue:**

- Closes #10329

Author: magic-akari

Diff for: .changeset/itchy-walls-repair.md

@@ -0,0 +1,6 @@
+---
+swc_core: patch
+swc_ecma_transforms_proposal: patch
+---
+
+fix(es/proposal): Fix scope of declarations for `explicit-resource-management`

Diff for: crates/swc/tests/fixture/issues-8xxx/8020/output/1.js

@@ -9,12 +9,12 @@ try {
     const foo = _ts_add_disposable_resource._(env, null, false);
     const bar = 1;
     console.log(baz());
+    function baz() {
+        return bar;
+    }
 } catch (e) {
     env.error = e;
     env.hasError = true;
 } finally{
     _ts_dispose_resources._(env);
 }
-function baz() {
-    return bar;
-}

Diff for: crates/swc/tests/fixture/issues-8xxx/8895/output/1.js

@@ -16,14 +16,14 @@ function main() {
     };
     try {
         const file = _ts_add_disposable_resource._(env, new File(), false);
+        function readFile() {
+            file.read();
+        }
         readFile();
     } catch (e) {
         env.error = e;
         env.hasError = true;
     } finally{
         _ts_dispose_resources._(env);
     }
-    function readFile() {
-        file.read();
-    }
 }

Diff for: crates/swc_ecma_transforms_proposal/src/explicit_resource_management.rs

@@ -135,20 +135,20 @@ impl ExplicitResourceManagement {
 
         for stmt in stmts.take() {
             match stmt.try_into_stmt() {
-                Ok(mut stmt) => {
-                    if matches!(stmt, Stmt::Decl(Decl::Fn(_)) | Stmt::Decl(Decl::Class(_))) {
-                        // function declarations should preserve original level
+                Ok(mut stmt) => match stmt {
+                    // top level function/class declarations should preserve original level
+                    Stmt::Decl(Decl::Fn(..) | Decl::Class(..)) if !self.is_not_top_level => {
                         extras.push(stmt.into());
-                    } else {
-                        if !self.is_not_top_level {
-                            if let Stmt::Decl(Decl::Var(ref mut var)) = stmt {
-                                // top level variable declarations should hoist
-                                var.kind = VarDeclKind::Var;
-                            }
-                        }
+                    }
+                    // top level variable declarations should hoist from inner scope
+                    Stmt::Decl(Decl::Var(ref mut var)) if !self.is_not_top_level => {
+                        var.kind = VarDeclKind::Var;
                         try_block.stmts.push(stmt);
                     }
-                }
+                    _ => {
+                        try_block.stmts.push(stmt);
+                    }
+                },
                 Err(t) => extras.push(t),
             }
         }

Diff for: crates/swc_ecma_transforms_proposal/tests/explicit-resource-management/issue-10329/1/input.js

@@ -0,0 +1,8 @@
+async function httpServerStreamingResponse() {
+  function periodicStream() {
+    console.log(counter);
+  }
+
+  let counter = 0;
+  await using server = test;
+}

Diff for: crates/swc_ecma_transforms_proposal/tests/explicit-resource-management/issue-10329/1/output.js

@@ -0,0 +1,20 @@
+async function httpServerStreamingResponse() {
+    const env = {
+        stack: [],
+        error: void 0,
+        hasError: false
+    };
+    try {
+        function periodicStream() {
+            console.log(counter);
+        }
+        let counter = 0;
+        const server = _ts_add_disposable_resource(env, test, true);
+    } catch (e) {
+        env.error = e;
+        env.hasError = true;
+    } finally{
+        const result = _ts_dispose_resources(env);
+        if (result) await result;
+    }
+}

Diff for: crates/swc_ecma_transforms_proposal/tests/explicit-resource-management/issue-10329/2/input.js

@@ -0,0 +1,19 @@
+async function httpServerStreamingResponse() {
+  function periodicStream() {
+    console.log(counter);
+  }
+
+  let counter = 0;
+  await using server = test;
+}
+
+function periodicStream() {
+  console.log(counter);
+}
+
+export function periodicStream2() {
+  console.log(counter);
+}
+
+let counter = 0;
+await using server = test;

Diff for: crates/swc_ecma_transforms_proposal/tests/explicit-resource-management/issue-10329/2/output.js

@@ -0,0 +1,41 @@
+const env = {
+    stack: [],
+    error: void 0,
+    hasError: false
+};
+try {
+    var counter = 0;
+    var server = _ts_add_disposable_resource(env, test, true);
+} catch (e) {
+    env.error = e;
+    env.hasError = true;
+} finally{
+    const result = _ts_dispose_resources(env);
+    if (result) await result;
+}
+async function httpServerStreamingResponse() {
+    const env = {
+        stack: [],
+        error: void 0,
+        hasError: false
+    };
+    try {
+        function periodicStream() {
+            console.log(counter);
+        }
+        let counter = 0;
+        const server = _ts_add_disposable_resource(env, test, true);
+    } catch (e) {
+        env.error = e;
+        env.hasError = true;
+    } finally{
+        const result = _ts_dispose_resources(env);
+        if (result) await result;
+    }
+}
+function periodicStream() {
+    console.log(counter);
+}
+export function periodicStream2() {
+    console.log(counter);
+}

Diff for: crates/swc_ecma_transforms_proposal/tests/explicit-resource-management/issue-10329/options.json

@@ -0,0 +1,3 @@
+{
+    "plugins": ["proposal-explicit-resource-management"]
+}