Skip to content

Fix missing .gitignore in empty dirs on dir rename #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mbaschnitzi
Copy link

The commandline option --empty-dirs now also has effect when a directory
was moved in svn.

Before there were no .gitignores added for empty dirs in a moved directory tree.

The commandline option --empty-dirs now also has effect when a directory
is moved in svn.
@Vampire
Copy link
Contributor

Vampire commented Apr 14, 2020

There are tests now. If you rebase on current master and add the attached file as empty-dirs.bats in directory test, you have test case that fails without your changes and succeeds with your changes. :-)

It has to be .bats, not .bats.txt, I just had to rename it to make GitHub file upload happy.

@Vampire
Copy link
Contributor

Vampire commented Apr 15, 2020

I added a pull-request to your pull-request branch, so you can also easily integrate the test. :-)
I even added a second one.

@tnyblom
Copy link
Contributor

tnyblom commented Apr 20, 2020

Merged in an updated form with PR 104, thanks for the patch!

@tnyblom tnyblom closed this Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants