Skip to content

Commit e41167e

Browse files
committed
refactor: update casting policy
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent bdc7714 commit e41167e

File tree

1 file changed

+1
-1
lines changed
  • lib/node_modules/@stdlib/blas/ext/sum/lib

1 file changed

+1
-1
lines changed

lib/node_modules/@stdlib/blas/ext/sum/lib/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ var idtypes = dtypes( 'numeric_and_generic' );
3333
var odtypes = dtypes( 'numeric_and_generic' );
3434
var policies = {
3535
'output': 'accumulation',
36-
'casting': 'promoted'
36+
'casting': 'none' // NOTE: in this case, we know that, at least for `gsum`, all scalar accumulation happens in double-precision, so casting an `int8` array to, e.g., `int32` is not necessary. Were we ever to implement specialized kernels beyond floating-point, we may need to revisit depending on the precision of the underlying accumulators.
3737
};
3838
var table = {
3939
'types': [

0 commit comments

Comments
 (0)