Skip to content

Commit 3488eeb

Browse files
committed
refactor test using selector
1 parent 5dc5801 commit 3488eeb

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/app/pages/home/feed/feed.component.spec.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -91,17 +91,17 @@ describe('FeedComponent', () => {
9191
const el = cmpDebugElement.nativeElement;
9292
expect(getDOM().querySelectorAll(el, 'li').length).toEqual(2);
9393

94-
const avatarLink = getDOM().querySelector(el, 'li>a');
95-
expect(avatarLink.getAttribute('href')).toEqual('/users/1');
94+
const avatarLink = getDOM().querySelector(el, 'li > a[href="/users/1"]');
95+
expect(avatarLink).toBeTruthy();
96+
97+
const userLink = getDOM().querySelector(el, 'li > span > a[href="/users/1"]');
98+
expect(userLink).toBeTruthy();
9699

97100
const gravatarDebugElement = cmpDebugElement.query(By.directive(GravatarComponent));
98101
expect(gravatarDebugElement).toBeTruthy();
99102
expect(gravatarDebugElement.componentInstance.hash).toEqual('9a3f499f653f7e8d4c5bf3ae0cf6418f');
100103
expect(gravatarDebugElement.componentInstance.alt).toEqual('test user1');
101104

102-
const userLink = getDOM().querySelector(el, 'span>a');
103-
expect(userLink.getAttribute('href')).toEqual('/users/1');
104-
105105
const firstItem = getDOM().querySelector(el, 'li');
106106
expect(firstItem.innerText).toMatch(/test user1/);
107107
expect(firstItem.innerText).toMatch(/content1/);
@@ -114,7 +114,7 @@ describe('FeedComponent', () => {
114114

115115
it('does not delete micropost when not confirmed', () => {
116116
const deleteLink = getDOM()
117-
.querySelector(cmpDebugElement.nativeElement, 'li:first-child > a:last-child');
117+
.querySelector(cmpDebugElement.nativeElement, 'li:first-child > a[href="#"]');
118118
spyOn(window, 'confirm').and.returnValue(false);
119119
spyOn(micropostService, 'delete');
120120
deleteLink.click();
@@ -125,7 +125,7 @@ describe('FeedComponent', () => {
125125
const cmp: FeedComponent = cmpDebugElement.componentInstance;
126126
const testCmp: TestComponent = testCmpDebugElement.componentInstance;
127127
const deleteLink = getDOM()
128-
.querySelector(cmpDebugElement.nativeElement, 'li:first-child > a:last-child');
128+
.querySelector(cmpDebugElement.nativeElement, 'li:first-child > a[href="#"]');
129129
spyOn(window, 'confirm').and.returnValue(true);
130130
spyOn(cmp, 'list');
131131
spyOn(testCmp, 'listenDeleted');

0 commit comments

Comments
 (0)