Skip to content

Commit c3fe8a0

Browse files
authored
Remove $(RemoveDevicePlatformSupport) workaround (dotnet#32191)
- current SDK does not include Android or iOS in the `@(SupportedPlatform)` item group
1 parent e554803 commit c3fe8a0

File tree

13 files changed

+1
-22
lines changed

13 files changed

+1
-22
lines changed

Directory.Build.targets

-9
Original file line numberDiff line numberDiff line change
@@ -175,15 +175,6 @@
175175
<BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
176176
</PropertyGroup>
177177

178-
<!--
179-
Where necessary, do not pretend we support iOS or Android. This file is imported after project
180-
has a chance to set $(RemoveDevicePlatformSupport) and long after @(SupportedPlatforms) is initialized.
181-
-->
182-
<ItemGroup Condition=" '$(RemoveDevicePlatformSupport)' == 'true' ">
183-
<SupportedPlatform Remove="Android" />
184-
<SupportedPlatform Remove="iOS" />
185-
</ItemGroup>
186-
187178
<Target Name="_CopySymbolsToArtifacts">
188179
<Copy SourceFiles="$([System.IO.Path]::ChangeExtension('$(TargetPath)', 'pdb'))"
189180
DestinationFolder="$(SymbolsOutputPath)$(TargetFramework)"

src/Components/WebAssembly/BlazorManifest/acquire/dotnet-install-blazoraot.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<AssemblyName>dotnet-install-blazoraot</AssemblyName>
1010
<PackageId>dotnet-install-blazoraot</PackageId>
1111
<GenerateDocumentationFile>false</GenerateDocumentationFile>
12-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
1312
<!-- Set this to false because there's nothing to reference here. -->
1413
<IsProjectReferenceProvider>false</IsProjectReferenceProvider>
1514
</PropertyGroup>

src/Components/WebAssembly/Server/src/Microsoft.AspNetCore.Components.WebAssembly.Server.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
55
<Description>Runtime server features for ASP.NET Core Blazor applications.</Description>
66
<IsShippingPackage>true</IsShippingPackage>
7-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
87

98
<!-- We're deliberately bundling assemblies as content files. Suppress the warning. -->
109
<NoWarn>$(NoWarn);NU5100</NoWarn>

src/Middleware/Spa/SpaProxy/src/Microsoft.AspNetCore.SpaProxy.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<PropertyGroup>
44
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
55
<Nullable>enable</Nullable>
6-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
76
<!-- This is ok since this assembly is not referenced by any application but it is loaded as a hosting startup
87
assembly for apps referencing this package-->
98
</PropertyGroup>

src/Middleware/Spa/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
<Description>Helpers for building single-page applications on ASP.NET MVC Core.</Description>
55
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
66
<Nullable>enable</Nullable>
7-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
87
</PropertyGroup>
98

109
<ItemGroup>
@@ -16,5 +15,5 @@
1615
<ItemGroup>
1716
<InternalsVisibleTo Include="Microsoft.AspNetCode.SpaServices.Extensions.Tests" />
1817
</ItemGroup>
19-
18+
2019
</Project>

src/ProjectTemplates/BlazorTemplates.Tests/BlazorTemplates.Tests.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
44
<TestGroupName>ProjectTemplates.E2ETests</TestGroupName>
55
<DefineConstants>$(DefineConstants);XPLAT</DefineConstants>
6-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
76

87
<RunTemplateTests Condition="'$(RunTemplateTests)' == ''">true</RunTemplateTests>
98
<SkipTests Condition="'$(RunTemplateTests)' != 'true'">true</SkipTests>

src/ProjectTemplates/test/ProjectTemplates.Tests.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
88
<TestGroupName>ProjectTemplates.E2ETests</TestGroupName>
99
<DefineConstants>$(DefineConstants);XPLAT</DefineConstants>
10-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
1110

1211
<RunTemplateTests Condition="'$(RunTemplateTests)' == ''" >true</RunTemplateTests>
1312
<SkipTests Condition="'$(RunTemplateTests)' != 'true'">true</SkipTests>

src/Security/Authentication/Negotiate/src/Microsoft.AspNetCore.Authentication.Negotiate.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
<GenerateDocumentationFile>true</GenerateDocumentationFile>
77
<PackageTags>aspnetcore;authentication;security</PackageTags>
88
<Nullable>enable</Nullable>
9-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
109
</PropertyGroup>
1110

1211
<ItemGroup>

src/Servers/Kestrel/Core/src/Microsoft.AspNetCore.Server.Kestrel.Core.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<IsPackable>false</IsPackable>
1212
<DefineConstants>$(DefineConstants);KESTREL</DefineConstants>
1313
<Nullable>enable</Nullable>
14-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
1514
</PropertyGroup>
1615

1716
<ItemGroup>

src/Tools/FirstRunCertGenerator/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
<Description>Package for the CLI first run experience.</Description>
66
<DefineConstants>$(DefineConstants);XPLAT</DefineConstants>
77
<PackageTags>aspnet;cli</PackageTags>
8-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
98

109
<!-- This package contains API for the .NET CLI to generate the aspnet HTTPs dev cert during CLI first-run initialization. -->
1110

src/Tools/Microsoft.dotnet-openapi/src/Microsoft.dotnet-openapi.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<AssemblyName>dotnet-openapi</AssemblyName>
88
<PackageId>Microsoft.dotnet-openapi</PackageId>
99
<PackAsTool>true</PackAsTool>
10-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
1110
</PropertyGroup>
1211

1312
<ItemGroup>

src/Tools/dotnet-dev-certs/src/dotnet-dev-certs.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<RootNamespace>Microsoft.AspNetCore.DeveloperCertificates.Tools</RootNamespace>
88
<PackageTags>dotnet;developercertificates</PackageTags>
99
<PackAsTool>true</PackAsTool>
10-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
1110
<!-- This package is for internal use only. It contains a CLI which is bundled in the .NET Core SDK. -->
1211
<IsShippingPackage>false</IsShippingPackage>
1312
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>

src/Tools/dotnet-user-secrets/src/dotnet-user-secrets.csproj

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<RootNamespace>Microsoft.Extensions.SecretManager.Tools</RootNamespace>
99
<PackageTags>configuration;secrets;usersecrets</PackageTags>
1010
<PackAsTool>true</PackAsTool>
11-
<RemoveDevicePlatformSupport>true</RemoveDevicePlatformSupport>
1211
<!-- This package is for internal use only. It contains a CLI which is bundled in the .NET Core SDK. -->
1312
<IsShippingPackage>false</IsShippingPackage>
1413
<ExcludeFromSourceBuild>false</ExcludeFromSourceBuild>

0 commit comments

Comments
 (0)