Skip to content

Commit 24628d8

Browse files
authored
Un-redact safe request/response headers in HttpLoggingMiddleware (dotnet#36307)
* Un-redact safe request/response headers in HttpLoggingMiddleware * Feedback
1 parent b46c5d5 commit 24628d8

File tree

1 file changed

+36
-2
lines changed

1 file changed

+36
-2
lines changed

src/Middleware/HttpLogging/src/HttpLoggingOptions.cs

+36-2
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,31 @@ public sealed class HttpLoggingOptions
3030
internal HashSet<string> _internalRequestHeaders = new HashSet<string>(StringComparer.OrdinalIgnoreCase)
3131
{
3232
HeaderNames.Accept,
33+
HeaderNames.AcceptCharset,
3334
HeaderNames.AcceptEncoding,
3435
HeaderNames.AcceptLanguage,
3536
HeaderNames.Allow,
37+
HeaderNames.CacheControl,
3638
HeaderNames.Connection,
39+
HeaderNames.ContentEncoding,
3740
HeaderNames.ContentLength,
3841
HeaderNames.ContentType,
42+
HeaderNames.Date,
43+
HeaderNames.DNT,
44+
HeaderNames.Expect,
3945
HeaderNames.Host,
40-
HeaderNames.UserAgent
46+
HeaderNames.MaxForwards,
47+
HeaderNames.Range,
48+
HeaderNames.SecWebSocketExtensions,
49+
HeaderNames.SecWebSocketVersion,
50+
HeaderNames.TE,
51+
HeaderNames.Trailer,
52+
HeaderNames.TransferEncoding,
53+
HeaderNames.Upgrade,
54+
HeaderNames.UserAgent,
55+
HeaderNames.Warning,
56+
HeaderNames.XRequestedWith,
57+
HeaderNames.XUACompatible
4158
};
4259

4360
/// <summary>
@@ -51,9 +68,26 @@ public sealed class HttpLoggingOptions
5168

5269
internal HashSet<string> _internalResponseHeaders = new HashSet<string>(StringComparer.OrdinalIgnoreCase)
5370
{
71+
HeaderNames.AcceptRanges,
72+
HeaderNames.Age,
73+
HeaderNames.Allow,
74+
HeaderNames.AltSvc,
75+
HeaderNames.Connection,
76+
HeaderNames.ContentDisposition,
77+
HeaderNames.ContentLanguage,
5478
HeaderNames.ContentLength,
79+
HeaderNames.ContentLocation,
80+
HeaderNames.ContentRange,
5581
HeaderNames.ContentType,
56-
HeaderNames.TransferEncoding
82+
HeaderNames.Date,
83+
HeaderNames.Expires,
84+
HeaderNames.LastModified,
85+
HeaderNames.Location,
86+
HeaderNames.Server,
87+
HeaderNames.Status,
88+
HeaderNames.TransferEncoding,
89+
HeaderNames.Upgrade,
90+
HeaderNames.XPoweredBy
5791
};
5892

5993
/// <summary>

0 commit comments

Comments
 (0)