Skip to content

Fix typing hints for None and bool types #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aaltat opened this issue May 24, 2020 · 0 comments · Fixed by #58
Closed

Fix typing hints for None and bool types #60

aaltat opened this issue May 24, 2020 · 0 comments · Fixed by #58
Assignees
@aaltat
Labels
enhancement priority: critical
Milestone
v2.1.0

Comments

@aaltat
Copy link
Contributor

aaltat commented May 24, 2020

PythonLibCore adds type hints for None and bool types when they are used as argument defaults. This causes problems for libdoc and those type hints should not be returned.
@aaltat aaltat self-assigned this May 24, 2020
@aaltat aaltat added this to the v2.1.0 milestone May 24, 2020
@aaltat aaltat mentioned this issue May 24, 2020
Merged
@aaltat aaltat closed this as completed in #58 Jun 1, 2020
aaltat added a commit that referenced this issue Jun 1, 2020
@aaltat
None and bool type should not return type hints when used as defaults…
edd411d 
… in RF31. (#58)

Made returning defaults for bool and NoneType work differently for RF31 and RF32. 

Fixes #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaltat aaltat

Labels
enhancement priority: critical
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

None and perhaps bool type should not return type hints when used as defaults. aaltat/PythonLibCore
1 participant
@aaltat