@@ -22,33 +22,31 @@ public class FeatureSetDescriptorTest
22
22
[ Test ]
23
23
public void Proto2Defaults ( )
24
24
{
25
- var expectedDefaults = new FeatureSet
26
- {
27
- EnumType = EnumType . Closed ,
28
- FieldPresence = FieldPresence . Explicit ,
29
- JsonFormat = JsonFormat . LegacyBestEffort ,
30
- MessageEncoding = MessageEncoding . LengthPrefixed ,
31
- RepeatedFieldEncoding = RepeatedFieldEncoding . Expanded ,
32
- Utf8Validation = Utf8Validation . None ,
33
- } ;
25
+ // Note: additional fixed features may be added in future Editions (features which
26
+ // have a value set to match preexisting proto2 behavior), so this is not an exhaustive
27
+ // list of all proto2 defaults.
34
28
var actualDefaults = FeatureSetDescriptor . GetEditionDefaults ( Edition . Proto2 ) . Proto ;
35
- Assert . AreEqual ( expectedDefaults , actualDefaults ) ;
29
+ Assert . AreEqual ( EnumType . Closed , actualDefaults . EnumType ) ;
30
+ Assert . AreEqual ( FieldPresence . Explicit , actualDefaults . FieldPresence ) ;
31
+ Assert . AreEqual ( JsonFormat . LegacyBestEffort , actualDefaults . JsonFormat ) ;
32
+ Assert . AreEqual ( MessageEncoding . LengthPrefixed , actualDefaults . MessageEncoding ) ;
33
+ Assert . AreEqual ( RepeatedFieldEncoding . Expanded , actualDefaults . RepeatedFieldEncoding ) ;
34
+ Assert . AreEqual ( Utf8Validation . None , actualDefaults . Utf8Validation ) ;
36
35
}
37
36
38
37
[ Test ]
39
38
public void Proto3Defaults ( )
40
39
{
41
- var expectedDefaults = new FeatureSet
42
- {
43
- EnumType = EnumType . Open ,
44
- FieldPresence = FieldPresence . Implicit ,
45
- JsonFormat = JsonFormat . Allow ,
46
- MessageEncoding = MessageEncoding . LengthPrefixed ,
47
- RepeatedFieldEncoding = RepeatedFieldEncoding . Packed ,
48
- Utf8Validation = Utf8Validation . Verify ,
49
- } ;
40
+ // Note: additional fixed features may be added in future Editions (features which
41
+ // have a value set to match preexisting proto2 behavior), so this is not an exhaustive
42
+ // list of all proto2 defaults.
50
43
var actualDefaults = FeatureSetDescriptor . GetEditionDefaults ( Edition . Proto3 ) . Proto ;
51
- Assert . AreEqual ( expectedDefaults , actualDefaults ) ;
44
+ Assert . AreEqual ( EnumType . Open , actualDefaults . EnumType ) ;
45
+ Assert . AreEqual ( FieldPresence . Implicit , actualDefaults . FieldPresence ) ;
46
+ Assert . AreEqual ( JsonFormat . Allow , actualDefaults . JsonFormat ) ;
47
+ Assert . AreEqual ( MessageEncoding . LengthPrefixed , actualDefaults . MessageEncoding ) ;
48
+ Assert . AreEqual ( RepeatedFieldEncoding . Packed , actualDefaults . RepeatedFieldEncoding ) ;
49
+ Assert . AreEqual ( Utf8Validation . Verify , actualDefaults . Utf8Validation ) ;
52
50
}
53
51
54
52
[ Test ]
0 commit comments