yak

Author: mgravell

examples/dotnet-grpc/DN_Client/Program.cs

@@ -3,7 +3,6 @@
 using Hyper;
 using MegaCorp;
 using System;
-using System.Net.Http;
 using System.Threading.Tasks;
 
 namespace Client

examples/dotnet-grpc/DN_Server/Program.cs

@@ -1,7 +1,6 @@
 using Microsoft.AspNetCore;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.Server.Kestrel.Core;
-using Microsoft.Extensions.Hosting;
 
 namespace DN_Server
 {

examples/pb-net/JustProtos/SomeType.cs

@@ -17,6 +17,7 @@ static void Foo()
                 typeof(TimeResult),
                 typeof(MultiplyRequest),
             };
+            _ = types;
         }
     }
 #pragma warning restore IDE0051, IDE0059

examples/perf/PerfClient/CodeFirst.cs

@@ -14,16 +14,16 @@ public sealed class IncrementResult
     [ServiceContract(Name = "PerfTest.VanillaGrpc")]
     public interface IVanillaGrpc
     {
-        public Task IncrementAsync();
+        Task IncrementAsync();
 
-        public Task<IncrementResult> ResetAsync();
+        Task<IncrementResult> ResetAsync();
     }
 
     [ServiceContract(Name = "PerfTest.ProtobufNetGrpc")]
     public interface IProtobufNetGrpc
     {
-        public Task IncrementAsync();
+        Task IncrementAsync();
 
-        public Task<IncrementResult> ResetAsync();
+        Task<IncrementResult> ResetAsync();
     }
 }

examples/perf/PerfServer/Program.cs

@@ -2,7 +2,6 @@
 using Microsoft.AspNetCore;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.Server.Kestrel.Core;
-using Microsoft.Extensions.Hosting;
 using PerfTest;
 using ProtoBuf.Grpc.Server;
 

src/protobuf-net.Grpc.AspNetCore.Reflection/ReflectionExtensions.cs

@@ -45,7 +45,7 @@ public static IServiceCollection AddCodeFirstGrpcReflection(this IServiceCollect
 
             // ReflectionService is designed to be a singleton
             // Explicitly register creating it in DI using descriptors calculated from gRPC endpoints in the app
-            services.TryAddSingleton<ReflectionService>(serviceProvider =>
+            services.TryAddSingleton(serviceProvider =>
             {
                 var binderConfiguration = serviceProvider.GetService<BinderConfiguration>();
                 var endpointDataSource = serviceProvider.GetRequiredService<EndpointDataSource>();

src/protobuf-net.Grpc/Client/GrpcClientFactory.cs

@@ -10,14 +10,14 @@ namespace ProtoBuf.Grpc.Client
     /// </summary>
     public static class GrpcClientFactory
     {
-        private const string Switch_AllowUnencryptedHttp2 = "System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport";
+        private const string SwitchAllowUnencryptedHttp2 = "System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport";
         /// <summary>
         /// Allows HttpClient to use HTTP/2 without TLS
         /// </summary>
         public static bool AllowUnencryptedHttp2
         {
-            get => AppContext.TryGetSwitch(Switch_AllowUnencryptedHttp2, out var enabled) && enabled;
-            set => AppContext.SetSwitch(Switch_AllowUnencryptedHttp2, value);
+            get => AppContext.TryGetSwitch(SwitchAllowUnencryptedHttp2, out var enabled) && enabled;
+            set => AppContext.SetSwitch(SwitchAllowUnencryptedHttp2, value);
         }
 
         /// <summary>

tests/protobuf-net.Grpc.Test.Integration/Issues/Issue107.cs

@@ -11,7 +11,7 @@
 using System.Threading.Tasks;
 using Xunit;
 using Xunit.Abstractions;
-
+#nullable disable
 namespace protobuf_net.Grpc.Test.Integration.Issues
 {
     public class Issue107 : IClassFixture<Issue107.MyServer<Issue107.Derived<string>>>
@@ -26,7 +26,7 @@ static MyServerBase()
         }
         public class MyServer<T> : MyServerBase, IDisposable, ICalculatorService<T>
         {
-            Server _server;
+            private readonly Server _server;
             public MyServer()
             {
                 _server = new Server

tests/protobuf-net.Grpc.Test.Integration/Issues/SO62732593.cs

@@ -5,7 +5,7 @@
 using System.ServiceModel;
 using System.Threading.Tasks;
 using Xunit;
-
+#nullable disable
 namespace protobuf_net.Grpc.Test.Integration.Issues
 {
     public class SO62732593