Skip to content

Difference between Instance and Static properties #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: 2.1.x
Choose a base branch
from
Open

Difference between Instance and Static properties #3906

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3dd65e7
WIP Instance vs Static properties
VincentLanglet Mar 28, 2025
1208925
Solve deprecations
VincentLanglet Mar 28, 2025
56c6e0f
Introduce new methods
VincentLanglet Mar 28, 2025
003b829
Solve tests
VincentLanglet Mar 28, 2025
f6c614e
More
VincentLanglet Mar 29, 2025
fedac7e
Solve deprecations
VincentLanglet Mar 29, 2025
f252ed4
Fix tests
VincentLanglet Mar 29, 2025
2321d10
Solve deprecations
VincentLanglet Mar 29, 2025
5254ade
Fix test
VincentLanglet Mar 29, 2025
2e344f6
Solve deprecation
VincentLanglet Mar 29, 2025
d8d5d6e
Add non regression test
VincentLanglet Mar 29, 2025
e092ef7
Review
VincentLanglet Mar 29, 2025
976116e
Solve todo
VincentLanglet Apr 20, 2025
13daba3
Fix deprecation
VincentLanglet Apr 20, 2025
8275d58
Fix
VincentLanglet May 13, 2025
bfd6fe5
Fix deprecation
VincentLanglet May 14, 2025
a848d4a
Fix
VincentLanglet May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Solve deprecation
  • Loading branch information
@VincentLanglet
VincentLanglet committed May 13, 2025
commit 2e344f6004f7e88e8991a815142b651097eee232
8 changes: 4 additions & 4 deletions src/Dependency/DependencyResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ public function resolveDependencies(Node $node, Scope $scope): NodeDependencies
}

if ($node->name instanceof Node\Identifier) {
$propertyReflection = $scope->getPropertyReflection($fetchedOnType, $node->name->toString());
$propertyReflection = $scope->getInstancePropertyReflection($fetchedOnType, $node->name->toString());
if ($propertyReflection !== null) {
$this->addClassToDependencies($propertyReflection->getDeclaringClass()->getName(), $dependenciesReflections);
}
Expand Down Expand Up @@ -369,13 +369,13 @@ public function resolveDependencies(Node $node, Scope $scope): NodeDependencies
$className = $scope->resolveName($node->class);
if ($this->reflectionProvider->hasClass($className)) {
$propertyClassReflection = $this->reflectionProvider->getClass($className);
if ($propertyClassReflection->hasProperty($node->name->toString())) {
$propertyReflection = $propertyClassReflection->getProperty($node->name->toString(), $scope);
if ($propertyClassReflection->hasStaticProperty($node->name->toString())) {
$propertyReflection = $propertyClassReflection->getStaticProperty($node->name->toString(), $scope);
$this->addClassToDependencies($propertyReflection->getDeclaringClass()->getName(), $dependenciesReflections);
}
}
} else {
$propertyReflection = $scope->getPropertyReflection($scope->getType($node->class), $node->name->toString());
$propertyReflection = $scope->getStaticPropertyReflection($scope->getType($node->class), $node->name->toString());
if ($propertyReflection !== null) {
$this->addClassToDependencies($propertyReflection->getDeclaringClass()->getName(), $dependenciesReflections);
}
Expand Down