-
-
Notifications
You must be signed in to change notification settings - Fork 105
Fix #478 - ALTER TABLE … MODIFY … ENUM('<reserved_keyword>')
is being wrongly parsed
#485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ALTER TABLE … MODIFY … ENUM('<reserved_keyword>')
is being wrongly parsed
@williamdes |
Nevermind, I will rebase this onto 5.x and do the merging stuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That feels definitely better than adding an edge case
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 5.8.x #485 +/- ##
============================================
- Coverage 97.02% 96.93% -0.10%
+ Complexity 2234 2233 -1
============================================
Files 69 69
Lines 5144 5150 +6
============================================
+ Hits 4991 4992 +1
- Misses 153 158 +5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, now it's unknown tokens
will this make lint errors or is this just unsupported options or the alter statement?
Could the set or enum be included into an Expression object?
From what I understand this was already the behavior but it was just not that much explicit in the out files
Unfortunately, on the AlterStatement, there are no properties about the type of the column to alter in the current operation. As far as I know, we have :
The expression representing the type of the column could be stored in the |
Signed-off-by: William Desportes <williamdes@wdes.fr>
😅 It's not, but that's OK, there's no trouble with that. Everything's fine to me! Thanks a lot! |
Seems like that's since a long time on your contributions, feel free to change it on your git settings. Merging 🚀 |
- Fixes phpmyadmin#511 - Reverts phpmyadmin#485 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
- Fixes phpmyadmin#511 - Reverts phpmyadmin#485 Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Fixes: #478
Fixes: #234