-
-
Notifications
You must be signed in to change notification settings - Fork 105
Incorrect order of operations to parse table/db called `` #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect order of operations to parse table/db called `` #422
Conversation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
I think you you also add a new test for this, check out the recent PRs for examples |
Codecov ReportBase: 97.25% // Head: 97.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
============================================
- Coverage 97.25% 97.23% -0.02%
Complexity 2196 2196
============================================
Files 68 68
Lines 5057 5057
============================================
- Hits 4918 4917 -1
- Misses 139 140 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@williamdes If you have time to do it I would be obliged. I don't have much familiarity with the parser yet. |
Signed-off-by: William Desportes <williamdes@wdes.fr>
Pull-request: #422 Signed-off-by: William Desportes <williamdes@wdes.fr>
I added a test in 19ce4bd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Ref: phpmyadmin/sql-parser#422 Signed-off-by: William Desportes <williamdes@wdes.fr>
A very minor error when the table name is
``