Skip to content

improve configuration of pthread link for userfaultd thread under NTS #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

improve configuration of pthread link for userfaultd thread under NTS #7568

merged 1 commit into from
Oct 11, 2021

Conversation

krakjoe
Copy link
Member

@krakjoe krakjoe commented Oct 11, 2021

  • Cache values must have cv in name.
  • Don't need to link pthread to all of php in NTS mode, just phpdbg.

@krakjoe krakjoe requested a review from bwoebi October 11, 2021 08:18
bwoebi
bwoebi reviewed Oct 11, 2021
View reviewed changes
Copy link
Member

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But heh, that's why I asked for the review of the config.m4 on the other PR :-D
I also wasn't aware that these apply to all :-)

@krakjoe krakjoe force-pushed the userfaultd-configure branch from c57149b to 998071c Compare October 11, 2021 10:15
@krakjoe
Copy link
Member Author

krakjoe commented Oct 11, 2021

That travis build fail looks somewhat ordinary for the current position of the moon. So merging, but will watch ...

@krakjoe krakjoe merged commit 0603d3b into php:master Oct 11, 2021
@krakjoe krakjoe deleted the userfaultd-configure branch October 11, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krakjoe @bwoebi