Fixed error reporting in mysqli_stmt::__construct #6454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Nov 25, 2020
ext/mysqli/mysqli.c
Outdated
|
|
||
| if (statement) { | ||
| if (mysql_stmt_prepare(stmt->stmt, statement, statement_len)) { | ||
| MYSQLI_REPORT_STMT_ERROR(stmt->stmt); |
There was a problem hiding this comment.
I don't understand why. I copied this from mysqli_stmt_prepare and there is no efree there. Besides I don't think that method allocates memory that I would need to deallocate myself. Can you explain it to me please?
There was a problem hiding this comment.
Because this is the funcion that allocates stmt (line 993). It will only be placed inside a resource below.
There was a problem hiding this comment.
Now I get it. I think I fixed it but can you please check if it is correct now?
kamil-tekiela
force-pushed
the
finish-mysqli_stmt-constructor
branch
3 times, most recently
from
f00e85d to
328838c
Compare
kamil-tekiela
force-pushed
the
finish-mysqli_stmt-constructor
branch
from
328838c to
c551242
Compare
nikic
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.