Skip to content

ext/sockets: adding IPPROTO_ICMP* constants for socket creations. #16737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ext/sockets/sockets.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -1647,6 +1647,20 @@
*/
const SOL_UDPLITE = UNKNOWN;
#endif
#if defined(IPPROTO_ICMP) || defined(PHP_WIN32)
/**
* @var int
* @cvalue IPPROTO_ICMP
*/
const IPPROTO_ICMP = UNKNOWN;
#endif
#if defined(IPPROTO_ICMPV6) || defined(PHP_WIN32)
/**
* @var int
* @cvalue IPPROTO_ICMPV6
*/
const IPPROTO_ICMPV6 = UNKNOWN;
#endif

#ifdef HAVE_IPV6
/**
Expand Down
8 changes: 7 additions & 1 deletion ext/sockets/sockets_arginfo.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

57 changes: 57 additions & 0 deletions ext/sockets/tests/socket_icmp.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
--TEST--
socket_create with IPPROTO_ICMP
--EXTENSIONS--
sockets
--SKIPIF--
<?php
if (!defined("IPPROTO_ICMP")) die("skip IPPROTO_ICMP not available");
// IPPROTO_ICMP* functions with raw sockets, thus requiring administrative role.
if (PHP_OS_FAMILY !== "Windows" && (!function_exists("posix_getuid") || posix_getuid() != 0)) die('skip IPPROTO_ICMP requires root permissions.');
?>
--FILE--
<?php

$host = '127.0.0.1';

$type = 8;
$code = 0;
$identifier = 16;
$sequence = 1;
$data = "ECHO";

$socket = socket_create(AF_INET, SOCK_RAW, IPPROTO_ICMP);
if (!$socket) {
die("Unable to create socket: " . socket_strerror(socket_last_error()) . "\n");
}

$header = pack('C2n3a*', $type, $code, 0, $identifier, $sequence, $data);
$checksum = function($header): int {
$bit = unpack('n*', $header);
$sum = array_sum($bit);

while ($sum >> 16) {
$sum = ($sum & 0xFFFF) + ($sum >> 16);
}
return ~ $sum & 0xFFFF;
};
$header = pack('C2n3a*', $type, $code, $checksum($header), $identifier, $sequence, $data);

if (!socket_sendto($socket, $header, strlen($header), 0, $host, 0)) {
die("Unable to send packet: " . socket_strerror(socket_last_error($socket)) . "\n");
}

$read = [$socket];
$write = $except = [];
$timeout = ['sec' => 4, 'usec' => 0];
if (socket_select($read, $write, $except, $timeout['sec'], $timeout['usec']) > 0) {
$response = '';
socket_recv($socket, $response, 65535, 0);
var_dump(bin2hex($response));
} else {
die("Unable to read the response\n");
}

socket_close($socket);
?>
--EXPECTF--
string(64) "%s"