Upgrade master to Ubuntu 24.04 #16704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
force-pushed
the
ubuntu-24.04
branch
from
ecc55d9 to
7d90e47
Compare
iluuu1994
commented
Nov 5, 2024
| @@ -2,7 +2,7 @@ | |||
| Test trampoline for curl option CURLMOPT_PUSHFUNCTION | |||
| --EXTENSIONS-- | |||
| curl | |||
| --XLEAK-- | |||
| --XFAIL-- | |||
There was a problem hiding this comment.
Upgrading to Ubuntu 24.04 (and curl 8.5.0) changes behavior of this test. Namely, it outputs:
Trampoline for trampoline
Array
...
@Girgias Can you make sense of this? Why wasn't the callback called before?
There was a problem hiding this comment.
It might have always been called, but does Ubuntu now have Caddy? As it might have been skipped before. And I didn't figure out how to get Caddy up and running locally?
There was a problem hiding this comment.
It recently started leaking, which is when I added the xleak. Hence, I'm pretty sure it wasn't skipped.
There was a problem hiding this comment.
Huuuuum, I'll have a look soon, maybe @Ayesh has an idea?
iluuu1994
requested review from
bukka,
NattyNarwhal,
SakiTakamachi,
devnexen,
adoy and
TimWolla
as code owners
devnexen
reviewed
Nov 5, 2024
|
I ok the pcntl part, changes are fine. |
SakiTakamachi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that Ubuntu 24.04 stopped compiling/distributing libtidy and libzip for i386, so I had to drop it from the build.