Fix assertion failure in zend_std_read_property #16639
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-16615.
We assert that
Z_PROP_FLAG_P(retval)
is exactlyIS_PROP_UNINIT
, but this is a bit field and it may contain irrelevant bits. For instance, props may also have theIS_PROP_LAZY
orIS_PROP_REINITABLE
bits, which does not change the fact that the property is uninitialized:@nielsdos I didn't update the comment because it's still correct, and I think that using equality comparison was unintended.