Skip to content

ext/standard/exec.c: combine conditions, update docs #16313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

ext/standard/exec.c: combine conditions, update docs #16313

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85439a3
ext/standard/exec.c: combine conditions, update docs
DanielEScherzer Sep 19, 2024
e6aa125
exec.c - better comment
DanielEScherzer Oct 9, 2024
c343357
exec.c - even better comment
DanielEScherzer Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ext/standard/exec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ PHPAPI int php_exec(int type, const char *cmd, zval *array, zval *return_value)
size_t buflen, bufl = 0;
#if PHP_SIGCHILD
void (*sig_handler)() = NULL;
#endif

#if PHP_SIGCHILD
sig_handler = signal (SIGCHLD, SIG_DFL);
#endif

Expand Down Expand Up @@ -272,8 +269,7 @@ PHP_FUNCTION(passthru)
Escape all chars that could possibly be used to
break out of a shell command

This function emalloc's a string and returns the pointer.
Remember to efree it when done with it.
This function returns an owned zend_string, remember to release it when done.

*NOT* safe for binary strings
*/
Expand Down