RecursiveTreeIterator::__construct(): switch @param to typehint
#16215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, looks like the offset* methods need to be compatible with parent methods - I'll switch this to just |
DanielEScherzer
force-pushed
the
spl-typehints
branch
from
4becc95 to
2e5b3c7
Compare
DanielEScherzer
changed the title
@param comments to actual typehints@param to typehint
The type is enforced, and `TypeError`s are already thrown, but the information about the required type is not provided to Reflection. Replace the `@param` comment with a real typehint so that the information is also available via Reflection.
DanielEScherzer
force-pushed
the
spl-typehints
branch
from
2e5b3c7 to
830fa0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type is enforced, and
TypeErrors are already thrown, but the information about the required type is not provided to Reflection. Replace the@paramcomment with a real typehint so that the information is also available via Reflection.