GH-16067: prevent invalid abstract during compilation of methods
#16069
Conversation
|
Closes #16067, CC @iluuu1994 |
DanielEScherzer
force-pushed
the
compiler-anon-abstract
branch
from
f0a1d74 to
2dcbfca
Compare
|
This is not really the right approach. Instead, what you should do is simply check in |
DanielEScherzer
force-pushed
the
compiler-anon-abstract
branch
from
2dcbfca to
c08b0ba
Compare
DanielEScherzer
changed the title
abstract in methods of anonymous classesabstract during compilation of methods
|
ABI break should be removed, no longer changes any header files |
Zend/zend_compile.c
Outdated
| // anonymous and can't be abstract | ||
| const char *msg; | ||
| if (ce->ce_flags & ZEND_ACC_ANON_CLASS) { | ||
| msg = "Anonymous class %s cannot contain abstract method %s::%s"; |
There was a problem hiding this comment.
I'm not sure there's a point in printing the class name twice? I don't have a strong opinion on this. Maybe @kocsismate does?
There was a problem hiding this comment.
I'm not sure there is a point other, but I couldn't really figure out a better way to do it - the message is about the class not being allowed to have abstract methods, and then the method name is usually given with the class name too. What would you think of ...abstract method ::foo without the class name?
There was a problem hiding this comment.
E.g. "Must not declare abstract method Foo::bar() in anonymous class" would be an option. But it's not a big deal.
DanielEScherzer
force-pushed
the
compiler-anon-abstract
branch
from
f4a6b53 to
64bc13c
Compare
|
<rebased, GitHub was saying there was a merge conflict but |
So that it is clear what changes
For classes that are not declared `abstract`, produce a compiler error for any `abstract` methods. For anonymous classes, since they cannot be made abstract, the error message is slightly different.
iluuu1994
force-pushed
the
compiler-anon-abstract
branch
from
64bc13c to
8dbb886
Compare
|
Thank you @DanielEScherzer! |
For classes that are not declared
abstract, produce a compiler error for anyabstractmethods. For anonymous classes and enums, since they cannot be made abstract, the error messages are slightly different.