-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add OPcache restart hook #15590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OPcache restart hook #15590
Conversation
72527d9
to
aa02ce7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this callback is really necessary:
- you should select a good place for it. I think it shouldn't be done under the exclusive lock.
- instead of
DL_FETCH_SYMBOL()
magic, it's better to declare the callback inzend.h
andzend.c
.
I'd need to try my prototype usage of that hook on x86 (so far only tested on aarch64), but the pointer that I can
It would remove the |
Hey there @dstogov can you have a look again? Would be great having this in 8.4 |
Hey folks,
adding to #15543 which allows access to OPcache shared globals, this hook will allow observing extensions to observe the actual OPcache restart using this code snippet:
CC: @arnaud-lb