-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Build/Windows: Update the Windows icon as svg and build derivatives from it #14964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…rom it Co-Authored-By: Nurudin Imsirovic <realnurudinimsirovic@gmail.com>
b0872eb
to
b56efb7
Compare
Thank you for reviewing this. Winget seems to have officially sourced |
I wasn't sure about that regarding other platform than Windows. On Windows, it was long time overdue, because of the system command
Agreed. I'm going to merge this PR soon, so we can have the nice icons already for PHP 8.4.0alpha2. |
I tested on Fedora 40 that comes with ImageMagic v7. |
I have no idea about the usage of ImageMagick v6 vs. v7. Maybe stick with |
I think you are right, it makes sense to stick to So for the state this PR is in now, it should work on the current IM version (v7) on Windows, as well as current IM version (v6) on latest Debian/Ubuntu/etc plus on Fedora too, albeit with the deprecation notice. This probably won't matter as much after all, we might need to update the scripts anyway by the time we come across to change the icons :) |
This is a follow-up to #12016. The author unfortunately deleted their
php-src
fork, which closed the PR. As mentioned in the previous PR, we have not updated the Windows icon in 21 years, and it look really dated:This takes the work from that PR, and the feedback it received to optimize the SVG.
In summary, this PR:
#777BB3
background. The source "php" text fill is then changed to#fff
.mkico.sh
and anmkico.bat
file to generate the.ico
files from the sourcesvg
file. The icon file embeds pixel sizes from 16,24,32,48,64,128, and 256 squares. That's why the new ico file is larger than the existing one. In Update icon after 20 years #12016, it usesmagick
command, but this one uses theconvert
command which should be available in ImageMagick 6 in latest Ubuntu LTS version.I did not copy the SVG files from
php/web-php
because it has rounded edges, and may only work out best for Windows app icons.