Skip to content

Fix incorrect charset length in check_mb_eucjpms() #13781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

No description provided.

Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How did you find that?

@nielsdos
Copy link
Member Author

nielsdos commented Mar 21, 2024

LGTM. How did you find that?

I was reading the code when I optimized this file a few weeks ago, and I just spotted this by accident.
At the time I didn't know yet if it was really a mistake or not, so I just wrote down in my notes to take a look at it.
I took a look just now and found it was indeed a mistake.

Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nielsdos nielsdos closed this in 8ffac99 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants