Remove HAVE_MYSQL #13719
Merged
Remove HAVE_MYSQL #13719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ext/pdo_mysql symbol has been once used together with the removed ext/mysql extension and isn't defined on Windows neither used in the code anymore.
|
Thanks for the review @SakiTakamachi I've also checked the community extensions out there and it doesn't seem to be any issues with this, so no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ext/pdo_mysql symbol has been once used together with the removed ext/mysql extension and isn't defined on Windows neither used in the code anymore.
Perhaps it would be better to define in the future either HAVE_PDO_MYSQL or similar for these extensions not dependent on the mysql or mysqli library driver. Or if extensions can successfully use
zend_hash_str_exists()...