Skip to content

CI: Cirrus CI - skip build on ignore-paths #13675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Ayesh
Copy link
Member

@Ayesh Ayesh commented Mar 11, 2024

Cirrus CI supports a <job>.skip key that skips the build if the expression evaluates to true. This adds the same list of on.pull_request.paths-ignore patterns from GitHub Actions workflows.

This should save several minutes of CI times on PRs when the changes are only in the README/doc files.

@Ayesh
Copy link
Member Author

Ayesh commented Mar 11, 2024

@Ayesh Ayesh marked this pull request as ready for review March 11, 2024 15:17
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Ayesh Ayesh force-pushed the cirrus-ci-skip-ignore-paths branch 3 times, most recently from e6e47d0 to 1a665a0 Compare March 19, 2024 15:21
@Ayesh Ayesh force-pushed the cirrus-ci-skip-ignore-paths branch 2 times, most recently from 31bb68c to bc16233 Compare March 23, 2024 19:34
@Ayesh
Copy link
Member Author

Ayesh commented Mar 23, 2024

Rebased after the openssl min version bump and FreeBSD image bump.

@Ayesh Ayesh force-pushed the cirrus-ci-skip-ignore-paths branch from bc16233 to b8c8359 Compare April 10, 2024 05:23
@Ayesh Ayesh force-pushed the cirrus-ci-skip-ignore-paths branch from b8c8359 to 696ece0 Compare May 6, 2024 10:50
@Ayesh Ayesh force-pushed the cirrus-ci-skip-ignore-paths branch from 696ece0 to 715a7d9 Compare September 19, 2024 02:23
@Ayesh
Copy link
Member Author

Ayesh commented Sep 19, 2024

Rebased and pushed, including some changes now that we no longer use Travis CI. Cirrus CI doc on the changesIncludeOnly function used in this PR.

Requesting @TimWolla if you could take a look too please? Thank you.

Cirrus CI supports a `<job>.skip` key that skips the build if the expression
evaluates to true. This adds the same list of `on.pull_request.paths-ignore`
patterns from GitHub Actions workflows.

This should save several minutes of CI times on PRs when the changes are
only in the README/doc files.

[Cirrus CI Docs](https://cirrus-ci.org/guide/writing-tasks/#supported-functions)
@Ayesh Ayesh force-pushed the cirrus-ci-skip-ignore-paths branch from 715a7d9 to 131fe02 Compare September 25, 2024 10:10
@cmb69 cmb69 merged commit f6a05e0 into php:master Sep 25, 2024
3 checks passed
@cmb69
Copy link
Member

cmb69 commented Sep 25, 2024

This has apparently forgotten. Sorry.

Thank you @Ayesh!

@Ayesh Ayesh deleted the cirrus-ci-skip-ignore-paths branch September 25, 2024 11:06
@iluuu1994
Copy link
Member

Sorry, I may have assumed you have commit karma. ^^

@cmb69
Copy link
Member

cmb69 commented Sep 25, 2024

May be time for php.net account, and commit karma for php-src? See https://www.php.net/git-php.php.

@Ayesh
Copy link
Member Author

Ayesh commented Sep 25, 2024

Thank you so much for your kind words! I submitted the form and have my fingers crossed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants