Skip to content

Zend/tests/offsets: Add tests where the offset is a reference #13506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2024
Merged

Zend/tests/offsets: Add tests where the offset is a reference #13506

merged 1 commit into from
Feb 26, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Feb 25, 2024

No description provided.

@Girgias Girgias requested a review from nielsdos February 25, 2024 16:46
@Girgias Girgias requested a review from iluuu1994 as a code owner February 25, 2024 16:46
nielsdos
nielsdos approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested it by breaking the reference support in read_dimension for the ArrayObject handler and it indeed finds the failure.

@Girgias Girgias merged commit 295a177 into php:master Feb 26, 2024
@Girgias Girgias deleted the offasets-as-references-tests branch February 26, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nielsdos