missing SKIP_SLOW_TESTS #13156
Merged
missing SKIP_SLOW_TESTS #13156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this test took 2 seconds to execute on a 5GHz AMD Ryzen 9 7950x (one of AMD's fastest single-thread-performance CPUs), it should have SKIP_SLOW_TESTS
iluuu1994
reviewed
Jan 17, 2024
| @@ -1,5 +1,9 @@ | |||
| --TEST-- | |||
| proc_open() with output socketpairs | |||
| --SKIPIF-- | |||
| <?php | |||
| if (getenv("SKIP_SLOW_TESTS")) die("SKIP_SLOW_TESTS"); | |||
There was a problem hiding this comment.
The message must start with skip ... or it won't actually be skipped.
There was a problem hiding this comment.
Ah, actually it will, likely by accident. The regex is /^skip\s*(.+)/i instead of /^skip\s+(.+)/i. Anyway, please stick to the existing convention.
There was a problem hiding this comment.
the existing convention
you sure there is one?
sapi/fpm/tests/reload-uses-sigkill-as-last-measure.phpt:
if (getenv('SKIP_SLOW_TESTS')) die('skip slow tests excluded by request');
tests/basic/timeout_variation_9.phpt:
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
ext/phar/tests/bug13727.phpt:
<?php if (getenv('SKIP_SLOW_TESTS')) die('skip'); ?>
ext/sockets/tests/socket_shutdown-win32.phpt:
if (getenv("SKIP_SLOW_TESTS")) {
die('skip: Slow test');
}
ext/curl/tests/bug64267.phpt:
if (getenv("SKIP_ONLINE_TESTS")) die("skip online test");
ext/soap/tests/bug69137.phpt:
if (getenv("SKIP_ONLINE_TESTS")) { die("skip test requiring internet connection"); }
There was a problem hiding this comment.
Sure, we're inconsistent. That doesn't mean we need yet another variation 😉
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this test took 2 seconds to execute on a 5GHz AMD Ryzen 9 7950x (one of AMD's fastest single-thread-performance CPUs), it should have SKIP_SLOW_TESTS