Fix registerNodeClass with abstract class crashing #12420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This always results in a segfault when trying to instantiate, so this never worked. At least throw an error instead of segfaulting to prevent developers from being confused.
staabm
reviewed
Oct 12, 2023
| $dom = new DOMDocument; | ||
|
|
||
| try { | ||
| $dom->registerNodeClass("DOMElement", "Test"); |
There was a problem hiding this comment.
Should there be another test for passing a enum?
There was a problem hiding this comment.
An enum cannot pass the instanceof_function(ce, basece) check. i.e. you'll get Argument #2 ($extendedClass) must be a class name derived from DOMElement or null, **enum name here** given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always results in a segfault when trying to instantiate, so this never worked.
At least throw an error instead of segfaulting to prevent developers from being confused.