Invalidate path even if the file was deleted

[mikhainin]

If the script was cached and deleted, the current implementation will not be able to invalidate it.
This change makes it still possible to delete script and then force its invalidation

[dstogov]

The patch makes sense. The minimal changes are requested.

I think, it may make sense to target this to PHP-8.3.
@adoy @bukka @ericmann @iluuu1994 what do you think?

[bukka]

This could be in some way considered as a bug fix so I'm fine this going to PHP 8.3.

@dstogov Do you see any issue with this going even to 8.2? Seems like logical behaviour to be able to invalidate deleted file.

[mikhainin]

Ooh, we seem to have a test checking this return value. Updated the test as well

[iluuu1994]

@dstogov Not that I object, but always returning true is the bigger BC break here, given that this function has previously returned false for both deleted and otherwise unlocatable files. As PHP is implementation defined, IMO we should adjust the documentation rather than the behavior. I could find at least a handful of usages where the result of opcache_invalidate is used.

https://sourcegraph.com/search?q=context:global+%22%3D+opcache_invalidate%28%22&patternType=standard&sm=1&groupBy=repo

[TimWolla]

I agree with Ilija here. Successfully resetting the cache for a file and telling the developer it failed is not great, but safe. Not successfully resetting the cache (because the realpath is different) and telling the developer it succeeded might be unsafe if the developer relies on the reset working.

[dstogov]

OK. I have to agree.

@mikhainin please revert it back and sorry for the noise.

[mikhainin]

Not a problem, returned the initial change - the test is now not broken and not changed

[dstogov]

@iluuu1994 please merge this into appropriate branch (I'm not sure 8.3 or 8.1).

[iluuu1994]

Great, thank you @mikhainin!