Skip to content

Commit e24d6c1

Browse files
committed
Remove redundant code
1 parent f3b3ad9 commit e24d6c1

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/lib/migrations/MysqlMigrationBuilder.php

-3
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ protected function buildColumnChanges(ColumnSchema $current, ColumnSchema $desir
2929
foreach ($changed as $attr) {
3030
$newColumn->$attr = $desired->$attr;
3131
}
32-
if (static::isEnum($newColumn)) {
33-
$newColumn->dbType = 'enum'; // TODO this is concretely not correct
34-
}
3532
$this->migration->addUpCode($this->recordBuilder->alterColumn($this->model->getTableAlias(), $newColumn))
3633
->addDownCode($this->recordBuilder->alterColumn($this->model->getTableAlias(), $current));
3734
}

tests/unit/EnumTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public function testChangeToAndFromEnum() // edit enum to string and vice versa
168168
$this->deleteTables();
169169
}
170170

171-
// TODO ENH enum change is more work than just changing the eunm values. And for PgSQL it is even more
171+
// TODO ENH enum change is more work than just changing the enum values. And for PgSQL it is even more
172172
// public function testEnumValuesChange()
173173
// {
174174
// $this->deleteTables();

0 commit comments

Comments
 (0)