Skip to content

Increase phpunit versions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmauerhan opened this issue Jun 9, 2016 · 3 comments
Closed

Increase phpunit versions #9

jmauerhan opened this issue Jun 9, 2016 · 3 comments

Comments

@jmauerhan
Copy link

Is there a reason this is locked to phpunit 4.0.0 || 5.0.0, and not something like 5.* ? If there's something breaking in one of the later versions, I'd be happy to help fix it. I want to use this tool with more recent phpunit versions.

@malkusch
Copy link
Member

malkusch commented Jun 9, 2016

Is there a reason this is locked to phpunit 4.0.0 || 5.0.0, and not something like 5.* ?

You omitted the caret constrain. It's locked against ^4.0.0 || ^5.0.0, not 4.0.0 || 5.0.0.

I want to use this tool with more recent phpunit versions.

Which particular version doesn't work for you?

@jmauerhan
Copy link
Author

When I originally tried to use it with phpunit 5.4, I got a version constraint error. Something else I changed must have fixed it, because now it's working...

However, when I was looking into if it would work, I noticed your travis isn't building with 5.4, so that could be added :) Thanks for the time!

@malkusch
Copy link
Member

However, when I was looking into if it would work, I noticed your travis isn't building with 5.4, so that could be added

Done in e47b67b. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants