added section for using Python logging module #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump. Just seeing if you had a chance to see this yet. |
ghost
approved these changes
May 14, 2022
ghost
approved these changes
May 14, 2022
| @@ -16,6 +16,7 @@ This describes reliable patterns of coding Python Extensions in C. It covers the | |||
| canonical_function | |||
| parsing_arguments | |||
| module_globals | |||
| logging | |||
| @@ -16,6 +16,7 @@ This describes reliable patterns of coding Python Extensions in C. It covers the | |||
| canonical_function | |||
| parsing_arguments | |||
| module_globals | |||
| logging | |||
paulross
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like the Python extension pattern docs. This is something I together to demonstrate how to log in an extension.
It is missing a few things:
This logging system has been implemented here.
The documentation is in draft mode and I haven't actually been able to verify the output in a browser yet, but I created the PR first to see if this is something you may want to include, and if you had any thoughts on how I could improve it.