Skip to content

Log the detailed exception when reconciliation #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Log the detailed exception when reconciliation #935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6d872f
Log the detailed exception when reconciliation
zuston Feb 15, 2022
b9f323c
fix: improve log message
metacosm Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

import java.util.List;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import io.fabric8.kubernetes.api.model.HasMetadata;
import io.fabric8.kubernetes.api.model.KubernetesResourceList;
import io.fabric8.kubernetes.api.model.apiextensions.v1.CustomResourceDefinition;
Expand Down Expand Up @@ -30,6 +33,8 @@
@SuppressWarnings({"unchecked"})
public class Controller<R extends HasMetadata> implements Reconciler<R>,
LifecycleAware, EventSourceInitializer<R> {
private static final Logger log = LoggerFactory.getLogger(Controller.class);

private final Reconciler<R> reconciler;
private final ControllerConfiguration<R> configuration;
private final KubernetesClient kubernetesClient;
Expand Down Expand Up @@ -98,7 +103,13 @@ public String successTypeName(UpdateControl<R> result) {

@Override
public UpdateControl<R> execute() {
return reconciler.reconcile(resource, context);
try {
return reconciler.reconcile(resource, context);
} catch (Exception e) {
log.error("Reconciliation error for resource: " + ResourceID.fromResource(resource)
+ " / reconciler: " + controllerName(), e);
throw e;
}
}
});
}
Expand Down