fix: add scope validation on custom resource #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
approved these changes
Feb 23, 2021
|
Thank you! |
metacosm
requested changes
Feb 23, 2021
There was a problem hiding this comment.
Actually, could you please change the commit message to conform to conventional commit format?
We should also probably remove the reference to upstreaming the checks to the client because I'm actually not sure if it's feasible in that context. We can do it here because we have access to the CRD but the client might not (i.e. it's not a given that the CRD will be retrieved any time a user interacts with the CRs).
daniellavoie
force-pushed
the
custom-resource-validation
branch
from
4420239 to
eb46a0b
Compare
daniellavoie
changed the title
metacosm
approved these changes
Feb 23, 2021
|
Thanks again! |
|
Avec plaisir! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339