Skip to content

chore: update to Quarkus 1.12.0 and fabric8 kubernetes-client 5.1.0 #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 22, 2021

Conversation

metacosm
Copy link
Collaborator

No description provided.

@metacosm metacosm self-assigned this Feb 18, 2021
Copy link
Collaborator

@adam-sandor adam-sandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return crd;
public void loadCRDAndApplyToCluster(String classPathYaml) {
var crd = loadYaml(CustomResourceDefinition.class, classPathYaml);
if ("apiextensions.k8s.io/v1".equals(crd.getApiVersion())) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather describe this as hackish but it works… 🤷🏼 😁

@metacosm metacosm merged commit b3d76cb into master Feb 22, 2021
@metacosm metacosm deleted the 5.1-upgrade branch February 22, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants