Skip to content

Add expected type for selectionLines property of editor.fold command #144732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cbliard
Copy link
Contributor

@cbliard cbliard commented Mar 9, 2022

This PR makes the expected type of selectionLines more explicit.

While authoring an extension involving the editor.fold command, I had issues using the selectionLines property. I submitted a number and did not understand it was expecting an array of numbers, until reading the source code to figure it out.

@aeschli aeschli merged commit fdd50be into microsoft:main Mar 9, 2022
@aeschli aeschli added this to the March 2022 milestone Mar 9, 2022
@aeschli aeschli added feature-request Request for new features or functionality editor-folding Editor code folding issues verification-needed Verification of issue is requested labels Mar 9, 2022
@cbliard cbliard deleted the better-doc-for-editor-fold-selection-lines branch March 9, 2022 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality verification-needed Verification of issue is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants