Skip to content

only exit zen mode by workbench.action.exitZenMode if its already in zen mode #144217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

kkakroo
Copy link
Contributor

@kkakroo kkakroo commented Mar 1, 2022

This PR fixes #140392

Issue

workbench.action.exitZenMode is toggling Zen mode.

Fix

For workbench.action.exitZenMode added a check to ensure Zen Mode is only toggled when it's actually in Zen Mode.

Test

  • Associate a shortcut to workbench.action.exitZenMode.
  • The shortcut only exits Zen Mode and doesn't toggle it anymore.

@kkakroo kkakroo changed the title only exit zen mode by workbench.action.exitZenMode if its already in Zen Mode only exit zen mode by workbench.action.exitZenMode if its already in zen mode Mar 1, 2022
@JacksonKearl JacksonKearl added this to the March 2022 milestone Mar 2, 2022
@JacksonKearl JacksonKearl merged commit 28a7e36 into microsoft:main Mar 2, 2022
@JacksonKearl
Copy link
Contributor

Thanks!

@kkakroo kkakroo deleted the exitZenMode-fix branch March 2, 2022 02:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command "workbench.action.exitZenMode" would turn on ZenMode when not in ZenMode
2 participants