Skip to content

Fix esbuild scripts #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Fix esbuild scripts #1154

merged 1 commit into from
Mar 11, 2025

Conversation

ratmice
Copy link
Contributor

@ratmice ratmice commented Mar 11, 2025

In 9fb82e1 the esbuild key in the scripts section was set to an esbuild version, this reverts that portion of the change.

In 9fb82e1 the esbuild key in the scripts
section was set to an esbuild version, this reverts that portion of the change.
@ratmice
Copy link
Contributor Author

ratmice commented Mar 11, 2025

@microsoft-github-policy-service agree

@ratmice
Copy link
Contributor Author

ratmice commented Mar 11, 2025

I should probably mention @mjbvz because it looks like a search/replace gone awry.
I didn't scour that PR but these are the 3 issues I did find.

Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@mjbvz mjbvz enabled auto-merge March 11, 2025 18:38
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 11, 2025
@mjbvz mjbvz merged commit 46f526c into microsoft:main Mar 11, 2025
2 checks passed
@ratmice ratmice deleted the fix_esbuild_scripts branch March 11, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants