Skip to content

Commit ba69392

Browse files
JesseColJesse Collins
and
Jesse Collins
authored
Change PR template (#425)
Co-authored-by: Jesse Collins <winappsdkdata_bot@microsoft.com>
1 parent 8bb871b commit ba69392

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Diff for: docs/pull_request_template.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@ Please specify which release this PR should align with. e.g., 1.0, 1.1, 1.1 Prev
1616

1717
## Checklist
1818

19+
Note that /azp run currently isn't working for this repo.
20+
1921
- [ ] Samples build and run using the Visual Studio versions listed in the [Windows development docs](https://docs.microsoft.com/windows/apps/windows-app-sdk/set-up-your-development-environment?tabs=stable#2-install-visual-studio).
2022
- [ ] Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
2123
- [ ] Samples set the minimum supported OS version to Windows 10 version 1809.
2224
- [ ] Samples build clean with no warnings or errors.
2325
- [ ] **[For new samples]**: Samples have completed the [sample guidelines checklist](https://github.com/microsoft/WindowsAppSDK-Samples/blob/main/docs/samples-guidelines.md#checklist) and follow [standardization/naming guidelines](https://github.com/microsoft/WindowsAppSDK-Samples/blob/main/docs/samples-guidelines.md#standardization-and-naming).
24-
- [ ] If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
25-
- [ ] I have commented on my PR `/azp run SamplesCI-<FeatureName>` to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.
26+
- [ ] Microsoft employees only: you can validate your changes by following the instructions here: https://www.osgwiki.com/wiki/WindowsAppSDK-Samples

0 commit comments

Comments
 (0)