Skip to content

Commit f8e3e85

Browse files
authored
Fix Linux Binary Creation (#66)
* Update linux.yml * Update linux.yml * Update linux.yml * Update package.json * Update package-lock.json * Revert * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Add dependency on nan * Update macos.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux.yml * Update linux and mac * Update macos.yml * Update linux.yml * Update linux.yml * Update linux.yml * Remove publish. Will manually upload for now. * Trigger builds. * Revert github action triggers.
1 parent 5e786c4 commit f8e3e85

File tree

5 files changed

+33
-22
lines changed

5 files changed

+33
-22
lines changed

Diff for: .github/workflows/linux.yml

+7-7
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ env:
77
NODE_PRE_GYP_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
88
jobs:
99
build:
10-
runs-on: ubuntu-latest
10+
runs-on: ubuntu-20.04
1111
continue-on-error: true
1212
strategy:
1313
fail-fast: true
@@ -19,17 +19,17 @@ jobs:
1919
uses: actions/setup-node@v2
2020
with:
2121
node-version: ${{ matrix.node-version }}
22-
- run: npm ci
22+
- run: npm install
2323
- run: npm run build:ts
2424
- run: npm run build
25-
- run: if [[ ${{ matrix.node-version }} == 14 ]]; then npm run lint; fi;
2625
- run: npm run package
2726
- uses: actions/upload-artifact@v2
2827
with:
2928
name: linux_artifact_${{ matrix.node-version }}
3029
path: build/stage/
3130
retention-days: 1
32-
- name: Publish
33-
# Publish not compatible with node 8, need to manually upload the files
34-
if: ${{ matrix.node-version != '8' }}
35-
run: npm run publish:github
31+
# - name: Publish
32+
# # Publish not compatible with node 8, need to manually upload the files
33+
# if: ${{ matrix.node-version != '8' }}
34+
# run: npm run publish:github
35+

Diff for: .github/workflows/macos.yml

+15-6
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,26 @@ env:
88
NODE_PRE_GYP_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
99
jobs:
1010
build:
11-
runs-on: macos-latest
11+
runs-on: macos-12
1212
continue-on-error: true
1313
strategy:
1414
fail-fast: true
1515
matrix:
1616
node-version: [8, 10, 12, 14, 15, 16, 17, 18, 19, 20, 21, 22]
1717
steps:
18+
- uses: actions/checkout@v2
19+
- name: Install setuptools
20+
uses: actions/setup-python@v3
21+
with:
22+
python-version: '3.9'
23+
- run: python3 -m pip install setuptools
24+
1825
- uses: actions/checkout@v2
1926
- name: Use Node.js ${{ matrix.node-version }}
2027
uses: actions/setup-node@v2
2128
with:
2229
node-version: ${{ matrix.node-version }}
23-
- run: npm ci
30+
- run: npm install
2431
- run: npm run build:ts
2532
- run: npm run build
2633
- run: npm run package
@@ -29,7 +36,9 @@ jobs:
2936
name: macos_artifact_${{ matrix.node-version }}
3037
path: build/stage/
3138
retention-days: 1
32-
- name: Publish
33-
# Publish not compatible with node 8, need to manually upload the files
34-
if: ${{ matrix.node-version != '8' }}
35-
run: npm run publish:github
39+
# - name: Publish
40+
# # Publish not compatible with node 8, need to manually upload the files
41+
# if: ${{ matrix.node-version != '8' }}
42+
# run: npm run publish:github
43+
44+

Diff for: .github/workflows/windows.yml

+6-4
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
uses: actions/setup-node@v2
2121
with:
2222
node-version: ${{ matrix.node-version }}
23-
- run: npm ci
23+
- run: npm install
2424
- run: npm run build:ts
2525
- run: npm run build
2626
- run: npm run package:windows
@@ -33,6 +33,8 @@ jobs:
3333
# Publish not compatible with node 8, need to manually upload the files
3434
if: ${{ matrix.node-version != 8 }}
3535
run: npm i @mmomtchev/node-pre-gyp-github
36-
- name: Publish
37-
if: ${{ matrix.node-version != 8 }}
38-
run: npm run publish:github:windows
36+
# - name: Publish
37+
# if: ${{ matrix.node-version != 8 }}
38+
# run: npm run publish:github:windows
39+
40+

Diff for: package-lock.json

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
},
3333
"dependencies": {
3434
"@mapbox/node-pre-gyp": "^1.0.11",
35-
"nan": "^2.17.0"
35+
"nan": "^2.20.0"
3636
},
3737
"devDependencies": {
3838
"@types/node": "^11.15.54",

0 commit comments

Comments
 (0)