Skip to content

Commit 79b0330

Browse files
authored
[llvm] Disable HandleLLVMOptions in runtimes mode (#73031)
Summary: There are a few default options that LLVM adds that can be problematic for runtimes builds. These options are generally intended to handle building LLVM itself, but are also added when building in a runtimes mode. One such issue I've run into is that in `libc` we deliberately use `--target` to use a different device toolchain, which doesn't support some linker arguments passed via `-Wl`. This is observed in #73030 when attempting to use these options. This patch completely removes these default arguments. The consensus is that any issues created by this patch should ultimately be solved on a per-runtime basis.
1 parent 6778dbe commit 79b0330

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

Diff for: runtimes/CMakeLists.txt

-2
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,7 @@ endif()
151151
# Avoid checking whether the compiler is working.
152152
set(LLVM_COMPILER_CHECKED ON)
153153

154-
# Handle common options used by all runtimes.
155154
include(AddLLVM)
156-
include(HandleLLVMOptions)
157155

158156
find_package(Python3 REQUIRED COMPONENTS Interpreter)
159157

0 commit comments

Comments
 (0)