Skip to content

Commit 55cfdc2

Browse files
committed
code review feedback
1 parent d536e46 commit 55cfdc2

File tree

9 files changed

+39
-38
lines changed

9 files changed

+39
-38
lines changed

Diff for: content/en/docs/reference/config-api/apiserver-audit.v1.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ be specified per rule in which case the union of both are omitted.</p>
253253
<td>
254254
<p>OmitManagedFields indicates whether to omit the managed fields of the request
255255
and response bodies from being written to the API audit log.
256-
This is used as a global default - a value of 'true' will omit the managed fields,
256+
This is used as a global default - a value of 'true' will omit the managed fileds,
257257
otherwise the managed fields will be included in the API audit log.
258258
Note that this can also be specified per rule in which case the value specified
259259
in a rule will override the global default.</p>
@@ -527,7 +527,7 @@ An empty list means no restrictions will apply.</p>
527527
and response bodies from being written to the API audit log.</p>
528528
<ul>
529529
<li>a value of 'true' will drop the managed fields from the API audit log</li>
530-
<li>a value of 'false' indicates that the managed fields should be included
530+
<li>a value of 'false' indicates that the managed fileds should be included
531531
in the API audit log
532532
Note that the value, if specified, in this rule will override the global default
533533
If a value is not specified then the global default specified in

Diff for: content/en/docs/reference/config-api/kubeadm-config.v1beta4.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Use <code>APIServer.ExtraEnvs</code>, <code>ControllerManager.ExtraEnvs</code>,
1616
<code>Etcd.Local.ExtraEnvs</code>.</li>
1717
<li>The <code>ResetConfiguration</code> API type is now supported in v1beta4.
1818
Users are able to reset a node by passing a <code>--config</code> file to <code>kubeadm reset</code>.</li>
19-
<li><code>dry-run</code> mode is now configurable in InitConfiguration and JoinConfiguration config files.</li>
19+
<li><code>dry-run</code> mode is now configureable in InitConfiguration and JoinConfiguration config files.</li>
2020
<li>Replace the existing string/string extra argument maps with structured extra arguments
2121
that support duplicates. The change applies to <code>ClusterConfiguration</code> - <code>APIServer.ExtraArgs</code>,
2222
<code>ControllerManager.ExtraArgs</code>, <code>Scheduler.ExtraArgs</code>. Also to <code>NodeRegistrationOptions.KubeletExtraArgs</code>.</li>

Diff for: content/en/docs/reference/config-api/kubelet-config.v1beta1.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ Default: 50</p>
545545
<td>
546546
<p>eventBurst is the maximum size of a burst of event creations, temporarily
547547
allows event creations to burst to this number, while still not exceeding
548-
eventRecordQPS. This field cannot be a negative number and it is only used
548+
eventRecordQPS. This field canot be a negative number and it is only used
549549
when eventRecordQPS &gt; 0.
550550
Default: 100</p>
551551
</td>

Diff for: content/en/docs/reference/config-api/kubelet-credentialprovider.v1.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ This response should be set to the same apiVersion as CredentialProviderRequest.
6363
<a href="#credentialprovider-kubelet-k8s-io-v1-PluginCacheKeyType"><code>PluginCacheKeyType</code></a>
6464
</td>
6565
<td>
66-
<p>cacheKeyType indicates the type of caching key to use based on the image provided
66+
<p>cacheKeyType indiciates the type of caching key to use based on the image provided
6767
in the request. There are three valid values for the cache key type: Image, Registry, and
6868
Global. If an invalid value is specified, the response will NOT be used by the kubelet.</p>
6969
</td>

Diff for: content/en/docs/reference/instrumentation/metrics.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1482,14 +1482,14 @@ Alpha metrics do not have any API guarantees. These metrics must be used at your
14821482
</ul>
14831483
</div><div class="metric" data-stability="alpha">
14841484
<div class="metric_name">ephemeral_volume_controller_create_failures_total</div>
1485-
<div class="metric_help">Number of PersistentVolumeClaims creation requests</div>
1485+
<div class="metric_help">Number of PersistenVolumeClaims creation requests</div>
14861486
<ul>
14871487
<li><label class="metric_detail">Stability Level:</label><span class="metric_stability_level">ALPHA</span></li>
14881488
<li data-type="counter"><label class="metric_detail">Type:</label> <span class="metric_type">Counter</span></li>
14891489
</ul>
14901490
</div><div class="metric" data-stability="alpha">
14911491
<div class="metric_name">ephemeral_volume_controller_create_total</div>
1492-
<div class="metric_help">Number of PersistentVolumeClaims creation requests</div>
1492+
<div class="metric_help">Number of PersistenVolumeClaims creation requests</div>
14931493
<ul>
14941494
<li><label class="metric_detail">Stability Level:</label><span class="metric_stability_level">ALPHA</span></li>
14951495
<li data-type="counter"><label class="metric_detail">Type:</label> <span class="metric_type">Counter</span></li>

Diff for: content/en/docs/reference/kubernetes-api/cluster-resources/api-service-v1.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ APIServiceSpec contains information for locating and communicating with a server
6262

6363
- **groupPriorityMinimum** (int32), required
6464

65-
GroupPriorityMinimum is the priority this group should have at least. Higher priority means that the group is preferred by clients over lower priority ones. Note that other versions of this group might specify even higher GroupPriorityMinimum values such that the whole group gets a higher priority. The primary sort is based on GroupPriorityMinimum, ordered highest number to lowest (20 before 10). The secondary sort is based on the alphabetical comparison of the name of the object. (v1.bar before v1.foo) We'd recommend something like: *.k8s.io (except extensions) at 18000 and PaaSes (OpenShift, Deis) are recommended to be in the 2000s
65+
GroupPriorityMininum is the priority this group should have at least. Higher priority means that the group is preferred by clients over lower priority ones. Note that other versions of this group might specify even higher GroupPriorityMininum values such that the whole group gets a higher priority. The primary sort is based on GroupPriorityMinimum, ordered highest number to lowest (20 before 10). The secondary sort is based on the alphabetical comparison of the name of the object. (v1.bar before v1.foo) We'd recommend something like: *.k8s.io (except extensions) at 18000 and PaaSes (OpenShift, Deis) are recommended to be in the 2000s
6666

6767
- **versionPriority** (int32), required
6868

Diff for: content/en/docs/reference/kubernetes-api/config-and-storage-resources/csi-driver-v1.md

+29-28
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ The file is auto-generated from the Go source code of the component using a gene
1515
[generator](https://github.com/kubernetes-sigs/reference-docs/). To learn how
1616
to generate the reference documentation, please read
1717
[Contributing to the reference documentation](/docs/contribute/generate-ref-docs/).
18-
To update the reference content, please follow the
18+
To update the reference content, please follow the
1919
[Contributing upstream](/docs/contribute/generate-ref-docs/contribute-upstream/)
2020
guide. You can file document formatting bugs against the
2121
[reference-docs](https://github.com/kubernetes-sigs/reference-docs/) project.
@@ -59,68 +59,68 @@ CSIDriverSpec is the specification of a CSIDriver.
5959
- **attachRequired** (boolean)
6060

6161
attachRequired indicates this CSI volume driver requires an attach operation (because it implements the CSI ControllerPublishVolume() method), and that the Kubernetes attach detach controller should call the attach volume interface which checks the volumeattachment status and waits until the volume is attached before proceeding to mounting. The CSI external-attacher coordinates with CSI volume driver and updates the volumeattachment status when the attach operation is complete. If the CSIDriverRegistry feature gate is enabled and the value is specified to false, the attach operation will be skipped. Otherwise the attach operation will be called.
62-
62+
6363
This field is immutable.
6464

6565
- **fsGroupPolicy** (string)
6666

6767
fsGroupPolicy defines if the underlying volume supports changing ownership and permission of the volume before being mounted. Refer to the specific FSGroupPolicy values for additional details.
68-
68+
6969
This field is immutable.
70-
70+
7171
Defaults to ReadWriteOnceWithFSType, which will examine each volume to determine if Kubernetes should modify ownership and permissions of the volume. With the default policy the defined fsGroup will only be applied if a fstype is defined and the volume's access mode contains ReadWriteOnce.
7272

7373
- **podInfoOnMount** (boolean)
7474

7575
podInfoOnMount indicates this CSI volume driver requires additional pod information (like podName, podUID, etc.) during mount operations, if set to true. If set to false, pod information will not be passed on mount. Default is false.
76-
76+
7777
The CSI driver specifies podInfoOnMount as part of driver deployment. If true, Kubelet will pass pod information as VolumeContext in the CSI NodePublishVolume() calls. The CSI driver is responsible for parsing and validating the information passed in as VolumeContext.
78-
79-
The following VolumeContext will be passed if podInfoOnMount is set to true. This list might grow, but the prefix will be used. "csi.storage.k8s.io/pod.name": pod.Name "csi.storage.k8s.io/pod.namespace": pod.Namespace "csi.storage.k8s.io/pod.uid": string(pod.UID) "csi.storage.k8s.io/ephemeral": "true" if the volume is an ephemeral inline volume
78+
79+
The following VolumeConext will be passed if podInfoOnMount is set to true. This list might grow, but the prefix will be used. "csi.storage.k8s.io/pod.name": pod.Name "csi.storage.k8s.io/pod.namespace": pod.Namespace "csi.storage.k8s.io/pod.uid": string(pod.UID) "csi.storage.k8s.io/ephemeral": "true" if the volume is an ephemeral inline volume
8080
defined by a CSIVolumeSource, otherwise "false"
81-
81+
8282
"csi.storage.k8s.io/ephemeral" is a new feature in Kubernetes 1.16. It is only required for drivers which support both the "Persistent" and "Ephemeral" VolumeLifecycleMode. Other drivers can leave pod info disabled and/or ignore this field. As Kubernetes 1.15 doesn't support this field, drivers can only support one mode when deployed on such a cluster and the deployment determines which mode that is, for example via a command line parameter of the driver.
83-
83+
8484
This field is immutable.
8585

8686
- **requiresRepublish** (boolean)
8787

8888
requiresRepublish indicates the CSI driver wants `NodePublishVolume` being periodically called to reflect any possible change in the mounted volume. This field defaults to false.
89-
89+
9090
Note: After a successful initial NodePublishVolume call, subsequent calls to NodePublishVolume should only update the contents of the volume. New mount points will not be seen by a running container.
9191

9292
- **seLinuxMount** (boolean)
9393

9494
seLinuxMount specifies if the CSI driver supports "-o context" mount option.
95-
95+
9696
When "true", the CSI driver must ensure that all volumes provided by this CSI driver can be mounted separately with different `-o context` options. This is typical for storage backends that provide volumes as filesystems on block devices or as independent shared volumes. Kubernetes will call NodeStage / NodePublish with "-o context=xyz" mount option when mounting a ReadWriteOncePod volume used in Pod that has explicitly set SELinux context. In the future, it may be expanded to other volume AccessModes. In any case, Kubernetes will ensure that the volume is mounted only with a single SELinux context.
97-
97+
9898
When "false", Kubernetes won't pass any special SELinux mount options to the driver. This is typical for volumes that represent subdirectories of a bigger shared filesystem.
99-
99+
100100
Default is "false".
101101

102102
- **storageCapacity** (boolean)
103103

104104
storageCapacity indicates that the CSI volume driver wants pod scheduling to consider the storage capacity that the driver deployment will report by creating CSIStorageCapacity objects with capacity information, if set to true.
105-
105+
106106
The check can be enabled immediately when deploying a driver. In that case, provisioning new volumes with late binding will pause until the driver deployment has published some suitable CSIStorageCapacity object.
107-
107+
108108
Alternatively, the driver can be deployed with the field unset or false and it can be flipped later when storage capacity information has been published.
109-
109+
110110
This field was immutable in Kubernetes \<= 1.22 and now is mutable.
111111

112112
- **tokenRequests** ([]TokenRequest)
113113

114114
*Atomic: will be replaced during a merge*
115-
115+
116116
tokenRequests indicates the CSI driver needs pods' service account tokens it is mounting volume for to do necessary authentication. Kubelet will pass the tokens in VolumeContext in the CSI NodePublishVolume calls. The CSI driver should parse and validate the following VolumeContext: "csi.storage.k8s.io/serviceAccount.tokens": {
117117
"\<audience>": {
118118
"token": \<token>,
119119
"expirationTimestamp": \<expiration timestamp in RFC3339>,
120120
},
121121
...
122122
}
123-
123+
124124
Note: Audience in each TokenRequest should be different and at most one token is empty string. To receive a new token after expiry, RequiresRepublish can be used to trigger NodePublishVolume periodically.
125125

126126
<a name="TokenRequest"></a>
@@ -137,13 +137,13 @@ CSIDriverSpec is the specification of a CSIDriver.
137137
- **volumeLifecycleModes** ([]string)
138138

139139
*Set: unique values will be kept during a merge*
140-
140+
141141
volumeLifecycleModes defines what kind of volumes this CSI volume driver supports. The default if the list is empty is "Persistent", which is the usage defined by the CSI specification and implemented in Kubernetes via the usual PV/PVC mechanism.
142-
142+
143143
The other mode is "Ephemeral". In this mode, volumes are defined inline inside the pod spec with CSIVolumeSource and their lifecycle is tied to the lifecycle of that pod. A driver has to be aware of this because it is only going to get a NodePublishVolume call for such a volume.
144-
144+
145145
For more information about implementing this mode, see https://kubernetes-csi.github.io/docs/ephemeral-local-volumes.html A driver can support one or more of these modes and more modes may be added in the future.
146-
146+
147147
This field is beta. This field is immutable.
148148

149149

@@ -297,7 +297,7 @@ POST /apis/storage.k8s.io/v1/csidrivers
297297

298298
- **body**: <a href="{{< ref "../config-and-storage-resources/csi-driver-v1#CSIDriver" >}}">CSIDriver</a>, required
299299

300-
300+
301301

302302

303303
- **dryRun** (*in query*): string
@@ -349,7 +349,7 @@ PUT /apis/storage.k8s.io/v1/csidrivers/{name}
349349

350350
- **body**: <a href="{{< ref "../config-and-storage-resources/csi-driver-v1#CSIDriver" >}}">CSIDriver</a>, required
351351

352-
352+
353353

354354

355355
- **dryRun** (*in query*): string
@@ -399,7 +399,7 @@ PATCH /apis/storage.k8s.io/v1/csidrivers/{name}
399399

400400
- **body**: <a href="{{< ref "../common-definitions/patch#Patch" >}}">Patch</a>, required
401401

402-
402+
403403

404404

405405
- **dryRun** (*in query*): string
@@ -454,7 +454,7 @@ DELETE /apis/storage.k8s.io/v1/csidrivers/{name}
454454

455455
- **body**: <a href="{{< ref "../common-definitions/delete-options#DeleteOptions" >}}">DeleteOptions</a>
456456

457-
457+
458458

459459

460460
- **dryRun** (*in query*): string
@@ -499,7 +499,7 @@ DELETE /apis/storage.k8s.io/v1/csidrivers
499499

500500
- **body**: <a href="{{< ref "../common-definitions/delete-options#DeleteOptions" >}}">DeleteOptions</a>
501501

502-
502+
503503

504504

505505
- **continue** (*in query*): string
@@ -568,4 +568,5 @@ DELETE /apis/storage.k8s.io/v1/csidrivers
568568

569569
200 (<a href="{{< ref "../common-definitions/status#Status" >}}">Status</a>): OK
570570

571-
401: Unauthorized
571+
401: Unauthorized
572+

Diff for: content/en/docs/reference/kubernetes-api/config-and-storage-resources/volume-attachment-v1.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ VolumeAttachmentSpec is the specification of a VolumeAttachment request.
7575
source represents the volume that should be attached.
7676

7777
<a name="VolumeAttachmentSource"></a>
78-
*VolumeAttachmentSource represents a volume that should be attached. Right now only PersistentVolumes can be attached via external attacher, in future we may allow also inline volumes in pods. Exactly one member can be set.*
78+
*VolumeAttachmentSource represents a volume that should be attached. Right now only PersistenVolumes can be attached via external attacher, in future we may allow also inline volumes in pods. Exactly one member can be set.*
7979

8080
- **source.inlineVolumeSpec** (<a href="{{< ref "../config-and-storage-resources/persistent-volume-v1#PersistentVolumeSpec" >}}">PersistentVolumeSpec</a>)
8181

Diff for: content/en/docs/reference/kubernetes-api/service-resources/endpoint-slice-v1.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ EndpointSlice represents a subset of the endpoints that implement a service. For
139139

140140
- **ports.name** (string)
141141

142-
name represents the name of this port. All ports in an EndpointSlice must have a unique name. If the EndpointSlice is derived from a Kubernetes service, this corresponds to the Service.ports[].name. Name must either be an empty string or pass DNS_LABEL validation: * must be no more than 63 characters long. * must consist of lower case alphanumeric characters or '-'. * must start and end with an alphanumeric character. Default is empty string.
142+
name represents the name of this port. All ports in an EndpointSlice must have a unique name. If the EndpointSlice is dervied from a Kubernetes service, this corresponds to the Service.ports[].name. Name must either be an empty string or pass DNS_LABEL validation: * must be no more than 63 characters long. * must consist of lower case alphanumeric characters or '-'. * must start and end with an alphanumeric character. Default is empty string.
143143

144144
- **ports.appProtocol** (string)
145145

0 commit comments

Comments
 (0)